Skip to content

Customizable Tank Sizes#355

Open
aquanight wants to merge 10 commits into
blkerby:mainfrom
aquanight:customize-tanksize
Open

Customizable Tank Sizes#355
aquanight wants to merge 10 commits into
blkerby:mainfrom
aquanight:customize-tanksize

Conversation

@aquanight

Copy link
Copy Markdown
Contributor

No description provided.

@aquanight aquanight marked this pull request as ready for review June 18, 2026 01:06
@blkerby

blkerby commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Could you change the wording to avoid referring to ammo packs as "tanks"? In Super Metroid, I think of "tanks" as referring to Energy Tanks and Reserve Tanks exclusively.

@aquanight

Copy link
Copy Markdown
Contributor Author

Will admit that possibility didn't occur to me, but I've updated the public-facing text (admittedly, 'tank' got thrown in the identifiers largely from when I was still looking at supporting modifying energy tanks as well).

@blkerby

blkerby commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Can you update the other identifiers too, not only the public-facing ones?

And then let's put the UI controls in a card inside of the Item Pool collapsible (rather than being its own "Ammo Size" collapsible directly under the Item Progression modal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants